SEZ9 commented on PR #11900: URL: https://github.com/apache/seatunnel/pull/11900#issuecomment-5578348443
@zhang-arvin thanks for the update. Comparing your summary with @DanielLeens's re-review of `ccd7d928e59`, two of the items you listed as addressed don't appear to be in the pushed commit: - **Test for listener deregistration when processor close throws (PR11900-F3):** the review reports that `JobHistoryServiceTest.java` as pushed only contains `testShutdownRemovesListeners`, which checks that `shutdown()` removes the three listeners but doesn't cover the case where the following step in `clearCoordinatorService()` throws. - **Independent instances in tests:** also reported as not present in the pushed test file. Could you check whether those changes were actually pushed, and if not, push them and list what the new commit contains so the description and diff line up? Separately, PR11900-F1 (the PR description claims metrics history persistence and a time-range query, but the diff only contains the listener-deregistration fix) is still open — please either update the description/title to match the change or point us to where that feature is implemented. The ordering fix (PR11900-F2), the boolean-result logging (PR11900-F4), and the indentation restore were reported as verified in the re-review, so no further action is expected on those. <!-- streview-comment:894 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
