DanielLeens commented on PR #11900: URL: https://github.com/apache/seatunnel/pull/11900#issuecomment-5645047657
Thanks for keeping this consolidated, @SEZ9 — matches my understanding exactly. I independently re-pulled `JobHistoryServiceTest.java` at the current head (`ccd7d928e59`, unchanged since my last pass) to re-confirm before replying: `testShutdownRemovesListeners()` (lines 154-196) still calls `jobHistoryService.shutdown()` directly on `server.getCoordinatorService().getJobHistoryService()` — the same shared, class-scoped instance `testlistJobState`/`testGetJobStatus` depend on — and it never drives `clearCoordinatorService()` with `resourceManager`/`eventProcessor`/`manager.close()` mocked to throw. So both F3 gaps (the throw-scenario coverage this PR exists to guarantee, and the test-isolation risk from reusing the shared instance) are confirmed still open, not just as-summarized but as directly observed in the current diff. Nothing else to add — no new commits since `ccd7d928e59`, so this isn't a re-review, just confirming the recap is accurate. Still waiting on @zhang-arvin for: (1) the `clearCoordinatorService()`-under-throw test, (2) an independently constructed `JobHistoryService` for it, and (3) the #11809 overlap answer, before the next full pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
