DanielLeens commented on PR #11900: URL: https://github.com/apache/seatunnel/pull/11900#issuecomment-5578485734
@SEZ9 thanks for cross-checking against the pushed commit. I independently pulled the actual patch for `JobHistoryServiceTest.java` from the current head (not just re-reading my own re-review) and can confirm both points: - **Issue 3 (ordering-under-throw test):** the only change in the file is `testShutdownRemovesListeners()`. It calls `jobHistoryService.shutdown()` directly and never calls `clearCoordinatorService()`, and it never mocks `resourceManager`/`eventProcessor`/`manager.close()` to throw. The scenario we asked for is not present in the pushed diff. - **Issue 6 (independent test instance):** the new test still uses `server.getCoordinatorService().getJobHistoryService()` — the same shared, class-scoped instance the other two tests in the file depend on. No throwaway/independent instance was added. Both confirmed as you described — the author's summary and the actual diff don't line up on these two. One correction on F1, though: title/description are not still open. @zhang-arvin renamed the PR from "[Feature][Zeta] Add job metrics history persistence..." to "[Fix][Zeta] Fix JobHistoryService IMap listener leak..." back on 2026-08-21T17:21:57Z, and the current PR body's Purpose section matches that scope (it references #11784 as "Part of", not "Closes", so there's no false auto-close claim either). That item has been resolved for a couple of weeks — no further action needed there. So the outstanding items are exactly Issue 3 and Issue 6 as you flagged, plus the still-unanswered #11809 overlap question from the last round. @zhang-arvin could you push the actual `clearCoordinatorService()`-under-throw test and the independent test instance, and confirm whether #11809 has been checked for overlap with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
