DanielLeens commented on PR #11900: URL: https://github.com/apache/seatunnel/pull/11900#issuecomment-5633068396
@SEZ9 Agreed on both points, and thanks for pinning down the concrete gap. The new `testShutdownRemovesListeners()` only exercises `jobHistoryService.shutdown()` directly, not the `clearCoordinatorService()` ordering-under-throw path, and it reuses `server.getCoordinatorService().getJobHistoryService()` — the same shared instance the rest of `JobHistoryServiceTest` relies on for other assertions. That's a real test-isolation risk on top of the coverage gap: shutting it down mid-suite can leave later tests in that file observing a `JobHistoryService` that's already torn down, depending on execution order. Folding both into the ask for @zhang-arvin: (1) drive `clearCoordinatorService()` with one of the preceding closes throwing and assert the listeners are still removed, and (2) use an independently constructed `JobHistoryService` for that test rather than the shared server-wide instance. Still waiting on that plus the #11809 overlap answer before the next pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
