SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5578430613
Thanks all for the quick follow-ups. @1328837476-hug — thanks for #12178 against `dev`. The described scope matches the slack slice as assigned: declarative nonblank validation for `webhooks_url`, `oauth_token`, and `slack_channel` with existing required status preserved, factory-only changes, and no contact with Slack or overlap with #12171's authentication fix. The coverage list (each option missing individually, empty, spaces, tabs, newlines, mixed whitespace, and nonblank values with surrounding spaces) is exactly what was requested. @nzw921rx's point about blank values failing at Slack call time is the motivation here, so this is the right place to catch it. Remaining ask: please confirm in the PR description that the connector docs (EN/ZH) either already state these options must be nonblank or were updated accordingly, so the reviewer can check that in one pass. @Nikk8091 — thanks for #12180 (web3j, `url` only) and #12181 (openmldb, `sql` only in both standalone and cluster modes). Both descriptions stay inside the approved slices: nonblank values and runtime behavior preserved, OpenMLDB conditional connection rules unchanged, and the exact configurations covered are listed. No further asks on those two beyond normal review. On the connector-sensorsdata proposal (`server_url` / `consumer` not registered in `SensorsDataSDKSinkFactory.optionRule()` at `8bea8c68`): that is a new scope rather than one of the slices decided above, so I won't confirm it in this reply. Please hold implementation until I have rechecked the tracker and open PRs for that connector and posted a decision here. When I do, the points you already flagged — verifying exact missing-value behavior first, and not making a console-only setting mandatory — are the ones I'll want stated explicitly in any resulting PR. <!-- streview-comment:897 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
