DanielLeens commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5645143313
Thanks, @SEZ9 — confirming your read of the delta and updating the CI picture with what's landed since my last review. **Delta confirmation.** Agreed: `af713e463f` vs `9e9dd08f9a` is exactly the two files I traced in my last review — the `seatunnel-starter/pom.xml` test-scope dependency cleanup and the `HttpReportPackagingIT.java` relocation into `connector-console-seatunnel-e2e`. Every other file in this PR is byte-identical to what's already been re-confirmed across the last several rounds, so there's nothing to re-litigate there. **CI update — the run has since completed, and the piece we were both waiting on is green.** At the time of my last review, `engine-v2-it (11, ubuntu-latest)` was still `queued`. It's since finished, along with the rest of the matrix. Pulling the fork run (`goutamadwant/seatunnel` run `34619448739`, this exact head) directly: - `Run / engine-v2-it (8, ubuntu-latest)`: `success` - `Run / engine-v2-it (11, ubuntu-latest)`: `success` Those are the two jobs that actually exercise this PR's diff — `FakeSourceToConsoleWithEventReportIT` and the relocated `HttpReportPackagingIT`, on both JDK 8 and JDK 11. That resolves the one blocker from my last review; I have no outstanding source-level or CI-completion concern on this head. **On the overall run showing `failure`:** I checked why. Eight jobs failed — `all-connectors-it-2` (8 and 11), `all-connectors-it-6` (8 and 11), `all-connectors-it-7` (8 and 11), and `paimon-connector-it` (8 and 11) — and every single one fails on the identical cause: `DatabendIT`, `IcebergSourceIT`, and `PaimonWithS3IT` all throw `ContainerFetchException`/`NotFoundException: pull access denied for minio/minio, repository does not exist or may require 'docker login'` trying to pull `minio/minio:RELEASE.2024-06-13T22-53-53Z`. None of those modules appear anywhere in this PR's `git diff --stat` (`seatunnel-engine-server`, `seatunnel-starter`, `connector-console-seatunnel-e2e`, docs, LICENSE, dependency manifest). This also isn't isolated to this PR — I'm seeing the same `minio/minio` pull-access-denied failure tonight on an unrelated PR's fork run as well, which points to a registry-side issue (Docker Hub now denying anonymous/unauthenticated pulls of that pinned tag) affectin g the whole CI fleet right now, not anything in this diff. Given both jobs that matter for this PR are green and the eight failures are conclusively unrelated (different modules, same registry-access error reproducing across PRs tonight), I'd treat this head as ready from my side — happy to see it move to approval rather than waiting on a rerun of the unrelated S3-backed connector jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
