SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5673898343
@goutamadwant thanks for the sync in c13a5357e and for running the focused HTTP handler tests on Java 11. The per-finding walkthrough posted earlier in this thread against d9855aee7d7 already gives concrete pointers for all of F1–F8: the wait strategy being installed before the server starts, the `close()` flushes gated on a terminated/non-interrupted scheduler with broadened exception handling and cancel-before-evict, the Kotlin BOM pin with aligned inventories, bounded `takeRequest` calls, redirects disabled, and the `Content-Type` assertion of `application/json; charset=utf-8`. I'll re-verify each of those directly against the diff in c13a5357e rather than ask you to restate them. The one item still open from my side is F1: since the wait-strategy ordering is exercised by the engine E2E run, please ping once the pending run finishes so I can confirm the event-report console IT passes there. Once that's green and my pass over the hunks checks out, I'm happy to move this forward. <!-- streview-comment:1056 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
