SEZ9 commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5691564349
Thanks @goutamadwant. Confirmed `c13a5357e` is a pure sync: diffing `d9855aee7d7..c13a5357e` scoped to the 11 PR-owned files shows no change, the branch has no divergence from `dev` (`0d9f9e2303`) beyond its own commits, and the "HTTP redirects are not followed" entry in both incompatible-changes docs is intact and not duplicated. Redirect handling (F7) is therefore addressed in both code and docs. Because the merge touched none of the reviewed files, the other findings from the `d9855aee7d7` review stand exactly as written, and I'll close each from the diff rather than from a description — no checklist needed. Two clarifications: - **F1**: this is structural — the wait strategy on "received new worker register" is set in `executeExtraCommands`, after the container lifecycle is configured, so a green engine E2E run would not show that it gates server readiness. It needs a code change, not a test result. That said, please still post the broader engine E2E outcome here once it finishes. - **F2 / F3**: the `close()` path was hardened in this PR; these are the residual points on that hardened path (flush racing a still-running task when the scheduler fails to terminate, and runtime failures other than `HazelcastInstanceNotActiveException`/`IOException` escaping `close()`). F4/F6 (kotlin-stdlib 1.8.21 vs kotlin-stdlib-common 1.9.10), F5, and F8 are likewise unchanged. Once the E2E result and the follow-up commits land, I'll do a final pass. <!-- streview-comment:1082 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
