SEZ9 commented on PR #12165: URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-5825585526
@Vivek1106-04 thanks for the detailed follow-up. **1. Wording.** The PR description changes you list cover what was asked: the shared dispatch thread framing in Section 3, the sleep-poll-inside-the-lock statement in Section 4 (as unchanged `dev` behaviour), the new section on savepoint lock holding not changing in this PR, and the section on the watchdog expiry change from `da0cbbf52` naming `testCheckpointExpiryHandlingNeverRunsOnTheDispatchThread`. Closed from my side. **2. Failed build on `c773cc091`.** Your attribution reads consistently to me. The `BackpressureSlowSinkIT` timeline shows every trigger firing on time, with the barrier reaching the source being what stalled, and the same assertion fails on the `dev` runs `34821874806` / `34801745423`. `PayPalClientTest` lives in `connector-http-paypal`, which this PR does not touch. The rerun on this head (`35729456152`) has already been gone through above, so I have nothing further to add on CI. **3. Sequencing.** Landing the same-coordinator part first and adding the cross-pipeline regression (written red first) once this PR is in works for me. No further changes requested from my side. <!-- streview-comment:1291 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
