Vivek1106-04 commented on PR #12165: URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-5829148838
@DanielLeens @SEZ9 Thank you both for the follow-up and for confirming that nothing further is requested. @DanielLeens, thank you for re-checking the rerun on `c773cc091` yourself, and for noting that this PR's engine tests have now passed on the Windows legs for the first time. @SEZ9, thank you for accepting the plan to land the same-coordinator fix first. I will write the cross-pipeline savepoint regression test in #12441 so that it fails before the fix, once this PR is in. @nzw921rx, my replies of 09-22 on your three review threads (the dispatch pool's size and configurability, the rejection path, and the lease's lifecycle) describe the code as it stands on the current head. The silent-stop case you raised is tracked in #12442. If any of those replies leaves a question open, please tell me and I will address it. Thanks again to everyone who reviewed this PR. The scheduler, its documentation and its tests are clearer for your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
