DanielLeens commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6078556694
Classification: I / Declarative OptionRule migration tracking. Thank you for the revised design and compatibility matrix. Variant B is the correct direction; do not use Variant A. `ReadonlyConfig.getOptional` tests raw configuration presence, so an extension attached only to `startup.mode` would not run when users omit that option and provide a `startup.specific-offset.*` value, leaving the most common wrong-mode case to fail only at runtime. Keep the existing runtime behavior unchanged and use connector-local, per-offset-option guards for that omitted-mode case. Retain a separate `specific` conditional requiring file and pos together; GTID and the two skip values must remain optional metadata, with their own nonblank/nonnegative constraints only when present. Before opening a PR, include `--check` tests for file+pos-only validity, partial/missing anchors, blank GTID, negative skips, every explicit wrong-mode offset, every omitted-mode offset, and OceanBase inheritance. No OptionRule DSL or runtime-path change is approved in this slice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
