SEZ9 commented on issue #12707: URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6104670435
Hi @karthik-0306, thanks for checking `seatunnel.sh` and for offering to pick this up — yes, that's fine with me. Please go ahead with the Java detection piece of PR 1 (JAVA_HOME first, then PATH, parse `java -version`, clear error below 11) as a module in `tools/seatunnel-python-sdk` with pytest tests. A couple of asks so it slots cleanly into the rest of the pip-install work: - Keep the detection logic in its own module with a small function that returns the resolved Java executable path and parsed major version, so the launcher can reuse it rather than re-implementing the parsing. - Please cover both older and newer `java -version` output formats in the pytest tests (mocking the command output is fine rather than requiring real JDKs in CI). - When Java is missing or below 11, the error message should say what was found (or that nothing was found) and point the user to set `JAVA_HOME` or install JDK 11+. Once you open the PR, link it back to this issue and I'll review it. If anything about the design doesn't fit, just raise it here and we can adjust. <!-- streview-comment:1663 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
