SEZ9 commented on issue #12707: URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6137065560
Hi @karthik-0306, thanks for the update and for moving quickly on this. I don't see a link to the PR in this thread yet — could you post the PR link here so it gets tied to this issue and I can pick it up for review? Once it's linked I'll go through it against the three points we agreed on: - Detection logic in its own module, with a small function returning the resolved Java executable path and parsed major version so the launcher can reuse it. - pytest coverage for both the older (e.g. 1.8.0_x) and newer (11, 17+) `java -version` output formats, with the command output mocked. - A clear error when Java is missing or below 11, stating what was found (or that nothing was found) and pointing to setting JAVA_HOME or installing JDK 11+. If any of those turned out to need adjustment while implementing, a short note in the PR description on what changed and why would help speed up the review. <!-- streview-comment:1708 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
