karthik-0306 commented on issue #12707: URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6111385522
@SEZ9, thank you for letting me pick this up, and for the clear guidance. I'll follow all three asks: - Detection logic in its own module, with a small function that returns the resolved Java executable path and the parsed major version, so the launcher can reuse it. - pytest tests covering both older (e.g. 1.8.0_x) and newer (11, 17+) `java -version` output formats, with the command output mocked. - A clear error when Java is missing or below 11, saying what was found (or that nothing was found) and pointing to setting JAVA_HOME or installing JDK 11+. If the overall design changes along the way, I'll adjust the module to match. I'll open the PR soon and link it to this issue. Please feel free to leave feedback there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
