DanielLeens commented on issue #12707: URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6249765657
Thanks for splitting the work into #12857 (SDK CI) and #12858 (the install-plugin helper). The CI PR has a successful Build; the helper PR is still waiting on its Build result. For the design point: keeping non-requested connector lines commented in the launcher-managed distribution copy is acceptable. `bin/install-plugin.sh` explicitly skips lines whose first character is `#`, and preserving those entries allows a later invocation to re-enable a connector without losing the section structure. Please make that ownership boundary explicit in #12858: this helper must mutate only a per-user/per-version launcher cache or other caller-owned copy, never a source checkout or a shared installation. Keep the idempotence and re-enable cases as regression tests. Classification: F — Python launcher implementation tracking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
