SEZ9 commented on PR #12079: URL: https://github.com/apache/seatunnel/pull/12079#issuecomment-6258910434
Thanks for the follow-up work on this. Based on the re-review at `612b5ede51`, here is where I see the previous points standing: **Looks addressed (pending my own pass over the head):** - F1 (duplicate output IDs double-decrementing) and F5 (scheduler duplicated between dry-run and `MultipleTableJobConfigParser`): the shared `TransformDependencyScheduler` releasing each waiting set only once, with both runtime parsing and connect dry-run going through it, is exactly the shape I was hoping for. - F2 / F4 / F6 (legacy fallback scope): narrowing the fallbacks to "final omitted/explicit-empty input" and "single-transform mismatch" is a reasonable compromise. Please confirm in the PR description which previously-accepted multi-transform configs now fail with `ConfigCheckException`, so we have that recorded for users. **Still open — please reply or push:** 1. **F3**: does the dry-run path still resolve inputs via `getInputIds` for validation while the scheduler uses `getTransformInputIds`? If both now go through a single resolution helper, point me to it; if not, please unify them so a divergence can't surface as a confusing "missing scheduled inputs" failure. 2. **F7**: I don't see any docs/changelog/upgrade-note change mentioned. Since cyclic or unresolved transform graphs now fail fast, please add a short note describing the new behavior and the retained fallbacks. 3. **F8**: please confirm whether `getOutputId()` is now used in production code, or remove it, and drop any remaining helpers that re-parse `ReadonlyConfig` where the existing resolution already exists. 4. The required `Build` check is reported as `FAILURE` on this head. Please get it green (or share the failure if it looks unrelated) before I do the final approval pass. Once those are in, I'll do a last read of the head and approve. <!-- streview-comment:1869 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
