DanielLeens commented on PR #12443: URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6266734946
Thanks @SEZ9 for the follow-up. I re-checked each point against the current head `5969894235228bd766a30ad02d9fcabe367f1e67` (unchanged since my last review, so these are exact locations). - **F1 / F5 (shared Map-to-Config path):** the guard is `ConfigMapPathUtils.quoteInvalidPathKeys`, applied immediately before `ConfigFactory.parseMap` in `ReadonlyConfig.java:79`, `ConfigBuilder.java:111` and `ConfigShadeUtils.java:229` (the decrypt re-parse). It is not private to `RestUtil`. - **F4 / F6 (coverage):** `RestUtilTest#buildConfigShouldPreserveRegexKeysFromJson`, `#buildConfigShouldPreserveTopLevelInvalidPathKey` and `#buildConfigShouldPreserveEscapedAndReservedKeysThroughConfigShade` cover regex, reserved and escaped keys through the shade/decrypt step, and `ConfigBuilderTest#testInvalidPathKeysSurviveConfigShadeRoundTrip` covers the `decryptConfig(ConfigBuilder.of(map))` round trip. `RestApiIT` and `RestApiSubmitJobConfigShadeDecryptTest` cover the submit path. - **F2 / F3 (docs):** the PR touches both `docs/en/engines/zeta/rest-api-v2.md` and `docs/zh/engines/zeta/rest-api-v2.md`; as I read them, keys rejected by the path parser stay literal while parsable keys keep the existing `->` / quote / whitespace normalization. - **F7 (title prefix):** the production changes are in `seatunnel-api` and `seatunnel-core-starter` (`ReadonlyConfig`, `ConfigMapPathUtils`, `ConfigBuilder`, `ConfigShadeUtils`); engine-server only gains tests. So `[Fix][Core]` looks like the right prefix to me, and I would not rename it to `[Fix][Zeta]`. The one remaining gate is CI: the apache-side `Build` check is `ACTION_REQUIRED`, so a runnable green run on this head is still needed before merge. @hutiefang76 could you make sure the fork workflows are enabled and the build runs on this head? Thanks again for the careful iteration! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
