SEZ9 commented on PR #12443:
URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6282364618
Thanks for the follow-ups, @hutiefang76.
I haven't yet been able to verify the `5969894235` and `f3f3a2d1e` changes
against the diff, so I'd like to keep the earlier points open until I can
confirm them from the code rather than from the description:
1. **decryptConfig re-parse** — could you point me to where in the diff the
shared guard is applied on the `ConfigShadeUtils.decryptConfig()` /
`ConfigFactory.parseMap` path, and to the test that exercises the decrypt round
trip with a key such as `^t_nova_.*$`?
2. **Shared guard scope** — which files changed to cover adapter loading,
variable backfill, and the user/system-variable map conversions? If the change
now touches modules outside `seatunnel-engine-server`, `[Fix][Core]` is fine;
otherwise `[Fix][Zeta]` would match the convention.
3. **Docs** — `rest-api-v2.md` in `docs/en` and `docs/zh` still needs to
describe which characters are now taken literally in JSON keys and what still
acts as a path separator.
4. **Key-rewrite semantics** — "valid path semantics stay unchanged"
suggests successfully-parsed keys can still be rewritten (`->` split into
nested paths, embedded quotes stripped, surrounding whitespace trimmed). Please
confirm that's the intended contract and document it so users know keys are not
preserved byte-for-byte.
5. **Tests** — please confirm the new tests include a key hitting `->`, a
key whose only offending token is `$` / `:` / `${...}`, an escape round trip
with `"` and `\` in a key, and a top-level key. The earlier "dotted key" test
didn't exercise the quoting path since `.` isn't a separator here. A
`RestApiIT` case for the REST submit path would also be welcome.
On CI: I don't know yet why dispatch returns HTTP 422 for your fork; I'll
look into triggering the upstream checks for this head. Thanks for being clear
that the local results aren't a substitute for a green run.
<!-- streview-comment:1894 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
