karthik-0306 commented on issue #12707:
URL: https://github.com/apache/seatunnel/issues/12707#issuecomment-6263763944
@SEZ9 thanks, glad the `#` approach works for you. Both asks are in #12858:
1. **Ownership boundary:** the module docstring (and the `seatunnel_home` /
`plugin_config_path` parameter docs) now state that the helpers rewrite
`config/plugin_config` in place and must only be given a caller-managed copy,
such as the launcher's per-user / per-version cache, never a source checkout or
a shared installation. I've added the same note to the PR description.
2. **Regression tests:** these are explicit tests in
`tests/test_plugin_installer.py`:
- idempotence: `test_second_run_with_same_connectors_is_idempotent`
(second run is byte-identical)
- re-enable: `test_previously_disabled_connector_can_be_enabled_again`
(`jdbc`, then `kafka`: `kafka` active, `jdbc` commented)
- mocked script call:
`test_runs_install_script_with_version_after_selecting`
@CryoThrust if you have time to try it against a real distribution on macOS
like last time, that would be great, but no pressure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
