SEZ9 commented on PR #12152: URL: https://github.com/apache/seatunnel/pull/12152#issuecomment-6283019830
Thanks @CryoThrust for checking the annotations on run `37615433319` rather than stopping at the missing logs. Since all 11 failed jobs report "The job was not started because it repeatedly failed to be acquired (5 attempts)", I agree these are runner-acquisition failures, not executed test failures, and they tell us nothing either way about the changed rejection path. On the F1/F2 side, the test mapping you laid out matches my reading: - `testCheckpointErrorReportDoesNotRunOnCallerThread` covers the propagation-after-release gap from F2 by verifying `handleCheckpointError(1, false)` once the busy executor is released. - `testCheckpointErrorReportRejectionStillReachesCancellationOffCallerThread` exercises a shut-down primary executor and checks handler delivery off the caller thread, which addresses the rejection/shutdown concern from F1. - `testCheckpointErrorReportCompletesFutureWhenExecutorRejects` checks waiter release. I also agree that none of these exercises rejection by both pools, and I am fine keeping that explicitly as the agreed follow-up rather than reading it into the passing tests. I have no new source-side finding on head `de042f22bf59bd2f039f04c06957b4b05010bc4c`. Remaining asks before merge: 1. Re-enable workflows on the fork from the signed-in Actions page, since you observed GitHub has paused them; the queued rerun does not establish that it has actually started. 2. Once enabled, rerun the failed jobs for the existing head so we get an executable CI run. A runner-acquisition failure cannot serve as verification, and no source change is needed just to chase that infrastructure state. 3. If any job then fails with a real test failure, please paste the job and test name here and I will classify it against the F1/F2 scope. <!-- streview-comment:1902 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
