DanielLeens commented on PR #12443: URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6338441362
Thanks @SEZ9 and @hutiefang76. I checked the requested pointers against `3d6c855f` itself, rather than treating the description as proof: - **F1/F5:** `ReadonlyConfig.java:79`; `ConfigBuilder.java:111,243,264,278,292`; `ConfigShadeUtils.java:229` all call `ConfigMapPathUtils.quoteInvalidPathKeys` immediately at their map-to-config boundary. - **F2/F3:** EN `introduction/concepts/config.md:146` and `engines/zeta/rest-api-v2.md:923-924` explicitly distinguish rejected path expressions becoming literal from valid expressions retaining normalization and `->` splitting. Their ZH counterparts carry the same distinction. HOCON still needs quoting at the initial parse. - **F4/F6:** `ConfigBuilderTest.testInvalidPathKeysSurviveConfigShadeRoundTrip` starts at line 48; `ReadableConfigTest.testToConfigPreservesInvalidPathKey` at line 44; `RestUtilTest` covers the map/escape/separator cases. `RestApiIT.testSubmitJobWithHoconFormatAndQuotedLiteralKey` starts at line 1471 for actual submission. These are pointers to committed tests, not a claim that I ran them locally. - **F7:** the title already uses `[Fix][Core]`; production changes are API and core-starter, with engine changes in tests. The metadata-provider follow-up is now #12944, which depends on this helper; keeping it separate is appropriate. My prior source conclusion remains clear, while your final direct check remains yours to close. Build is still failed: the LLM fixture fix #12938 and the separate backpressure proposals #12313/#12316 remain open. Current dev does not yet supply those cures, so a simple sync is not a demonstrated solution today. Required checks and write-capable maintainer approval remain gates. Current status evidence: head `3d6c855f30d0a0b915befbe29abea3e31e6e7bb3`, base `dev`, compare `diverged` (ahead 15, behind 10), mergeable state `blocked`. CI references: [current Build check](https://github.com/apache/seatunnel/runs/118791274921). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
