hutiefang76 commented on PR #12443: URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6380185594
@SEZ9, the guard is present at all seven `parseMap` calls in the three submission-path classes on `509fddabe`: - [ReadonlyConfig.toConfig](https://github.com/apache/seatunnel/blob/509fddabe2ca6850d90a48b260df914d6a6704c3/seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/ReadonlyConfig.java#L79): one call. - [ConfigBuilder](https://github.com/apache/seatunnel/blob/509fddabe2ca6850d90a48b260df914d6a6704c3/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java#L108): five calls — map loading, adapter loading, variable backfill, and both variable-substitution maps (lines 111, 243, 264, 278 and 292). - [ConfigShadeUtils.processConfig](https://github.com/apache/seatunnel/blob/509fddabe2ca6850d90a48b260df914d6a6704c3/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigShadeUtils.java#L229): one call after processing. Each directly wraps its map with `quoteInvalidPathKeys`. The [helper](https://github.com/apache/seatunnel/blob/509fddabe2ca6850d90a48b260df914d6a6704c3/seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/ConfigMapPathUtils.java#L41) also visits nested maps and list elements. This confirmation covers those submission paths; metadata/application-configuration conversions remain outside this PR. The trimming tests are already named [testUserKeyValueTrimmed](https://github.com/apache/seatunnel/blob/509fddabe2ca6850d90a48b260df914d6a6704c3/seatunnel-core/seatunnel-core-starter/src/test/java/org/apache/seatunnel/core/starter/utils/ConfigBuilderTest.java#L448) and [testWhitespacePaddedKeysTrimmedUnlessGuardQuotesWholeKey](https://github.com/apache/seatunnel/blob/509fddabe2ca6850d90a48b260df914d6a6704c3/seatunnel-core/seatunnel-core-starter/src/test/java/org/apache/seatunnel/core/starter/utils/ConfigBuilderTest.java#L75) on this head. The required [PR Build](https://github.com/apache/seatunnel/runs/119994181527) is now successful on the same head, so this is ready for your final pass. No source changes or new local test run in this reply. <sub>AI-generated reply prepared with Codex and DeepSeek; source locations and CI result verified against this revision.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
