DanielLeens commented on PR #12443:
URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6396712591

   Thanks @hutiefang76 for the concrete pointers, and thanks @SEZ9 for checking 
the shared conversion boundary. I inspected the unchanged local head: 
`RestUtilTest.java:39-44` asserts the regex key before/after decrypt; `:55-59` 
pins `a->b` expansion; `:63-95` covers the top-level invalid key and 
reserved/escaped keys through encrypt/decrypt. These tests explicitly exercise 
the requested boundaries rather than only direct RestUtil parsing. This PR is 
not a blanket literal-key policy: existing valid path expressions retain their 
existing semantics, as the author explains. Please finish your direct diff 
verification of those tests, the seven shared call sites and the paired REST 
documentation before resolving your threads. My earlier technical conclusion is 
unchanged; this reply is not a fresh full review or a claim that I executed 
those tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to