hutiefang76 commented on PR #12443: URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6392767800
@SEZ9, these are already covered on unchanged `509fddabe`: - **Key semantics:** yes, valid `a->b` still becomes a nested path and quotes in parsable keys are removed. That is intentional compatibility with the existing path parser. Only keys rejected as invalid paths are quoted as literals; the PR does not make every JSON key literal. Both [English](https://github.com/apache/seatunnel/blob/509fddabe2ca6850d90a48b260df914d6a6704c3/docs/en/engines/zeta/rest-api-v2.md#L923-L924) and [Chinese](https://github.com/apache/seatunnel/blob/509fddabe2ca6850d90a48b260df914d6a6704c3/docs/zh/engines/zeta/rest-api-v2.md#L894-L895) REST API v2 docs describe this, including the HOCON distinction. - **Tests:** [RestUtilTest](https://github.com/apache/seatunnel/blob/509fddabe2ca6850d90a48b260df914d6a6704c3/seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/utils/RestUtilTest.java#L40-L111) covers regex keys through decrypt, a top-level invalid key, `a->b`, and `$`, `:`, `${FOO}` plus an embedded quote/backslash through encrypt/decrypt. `ConfigBuilderTest.testInvalidPathKeysSurviveConfigShadeRoundTrip` covers the shared builder/shade path; `RestApiSubmitJobConfigShadeDecryptTest.testSubmitJobWithRegexFieldInJson` covers REST submission. <sub>AI-assisted reply (Codex), checked against the linked revision.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
