SEZ9 commented on PR #12443: URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6380024938
Thanks for the detailed walkthrough against `509fddabe` (merge of `dev` on top of `3d6c855f`). The summary addresses each of my earlier points: the `decryptConfig` re-parse now going through the shared quoting helper (F1/F5), the quote-only-on-BadPath contract being documented in EN and ZH (F2/F3), the added shade round-trip, escaped-key, `a->b`, REST decrypt and IT coverage (F4/F6), and the module scope for the title (F7). That all sounds right, but I have not yet verified it against the diff myself, so I am not closing these findings on the strength of the description alone. I will re-check the actual changes before signing off. Two small asks in the meantime: 1. For F5, please confirm the quoting helper is applied at every `Map -> Config` boundary that was listed, not only the `ConfigShadeUtils` site. 2. The whitespace test in `ConfigBuilderTest` now exercises trimming rather than a separator, so a label matching what it tests would help (non-blocking). Please ping once CI is green on the current head and I will do the final pass. <!-- streview-comment:2003 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
