SEZ9 commented on PR #11613:
URL: https://github.com/apache/seatunnel/pull/11613#issuecomment-6357268560
Thanks for syncing the branch with `dev` (b607bd554, up to 99ea16b9d6) and
for 4aba1e6892 ("Gate checkpoint restore controls on terminal jobs"). Here is
where each of my earlier points stands on the new head.
**Resolved / largely addressed**
- **F3 (auth on the new servlets)** – `/update-local-member-tags` and
`/http-service/status` are registered in `JettyService` alongside the existing
servlets, so they sit behind the same basic-auth/mTLS chain; the status
response exposes only switches, ports and context path, and the audit log
records only a tag count. No further ask here.
- **F6 (restore guard)** – 4aba1e6892 together with the server-side
`validateCheckpointRestoreRequest` path (400 for non-numeric IDs, 400 for a
source job that is not in an end state, fall-through to the existing "No
checkpoint found" path otherwise) covers the gap I raised. Please add a few
sentences to `docs/en/engines/zeta/web-ui.md` describing what the user sees
when the source job is still running vs. when its checkpoint state has been
cleaned up, and this is closed.
**Still open – concrete asks**
- **F1** – In `docs/en/engines/zeta/rest-api-v2.md`, rename the misleading
key in the `/update-tags` example to something flat and unambiguous, and add
one sentence stating that values must be strings (flat `Map<String,String>`,
nested objects rejected).
- **F2** – The server-side diff is unchanged since 9dc0aede18, so there is
still no `RestApiIT`/E2E coverage. Please add E2E cases for (a)
`/update-local-member-tags` happy path and UUID mismatch, (b) the
`/http-service/status` response shape, and (c) a legacy `/update-tags` call to
lock in the flat-map contract.
- **F4** – The local-only UUID check means tag updates from the UI will fail
behind a load balancer or when only the master serves the Web UI. Either
document this limitation prominently in `rest-api-v2.md`/`web-ui.md`, or
explain in the PR how the UI resolves the right member in those topologies.
- **F5** – `/update-local-member-tags` still needs its own section in
`rest-api-v2.md` with a request example, success response, and error examples
(UUID mismatch, non-string value).
- **F7** – Add per-field descriptions for the `/http-service/status`
response and change the example port from 5801 to 8080 to match the rest of the
document.
- **F8** – `web-ui.md` describes the new Action controls, Submit Job panel,
Checkpoints tab and Operations page but still ships only the old screenshots.
Please add screenshots for the new surfaces, or drop the stale ones if you'd
prefer to keep the doc text-only.
Once F1, F2, F5 and F7 land and F4/F6/F8 are either documented or explained,
I'm happy to take another full pass.
<!-- streview-comment:1974 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
