davidzollo commented on PR #11613: URL: https://github.com/apache/seatunnel/pull/11613#issuecomment-6432796605
@SEZ9 thanks for the pass on `117cf5289a`. @DanielLeens has already mapped F1 to F7 to the code on this head, so only two points from me: - **F1 wording**: the legacy `/update-tags` section intentionally says non-string values are *converted* to strings rather than rejected, because that is what the server does today and what existing clients rely on. Saying "nested objects rejected" there would misdocument the legacy path. The strict "values must be strings, 400 otherwise" rule lives on the new `/update-local-member-tags` endpoint, whose error table lists it. - **F8 (screenshots)**: taking you up on the follow-up offer. Producing them needs a running UI against fixtures (the existing worker screenshots were captured locally with Cypress fixtures, and CI does not run Cypress), so I'd like to split them into a separate docs PR rather than hold this one. The stale Running Jobs and Job Detail images were already removed. **CI evidence for this head**: fork Actions on `danielnadean/seatunnel` are still disabled by GitHub's usage-based banner, so the `Build` check here cannot refresh until the fork owner clicks enable on the fork's Actions page. In the meantime the exact head `117cf5289a` is building on another fork: https://github.com/DanielLeens/seatunnel/actions/runs/40442657287 (branch `pr11613-verify-117cf528`). I'll compare any failure there against the diff once it finishes. The PR stays in Draft until a green `Build` is attached to the head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
