SEZ9 commented on PR #12443: URL: https://github.com/apache/seatunnel/pull/12443#issuecomment-6406660943
Thanks @hutiefang76 for the pointers. - **Key semantics / docs:** Understood that only keys rejected as invalid paths are quoted as literals, while parsable keys such as `a->b` keep their existing path semantics, and that both the English and Chinese `rest-api-v2.md` describe this including the HOCON distinction. I'll read those doc changes on `509fddabe` directly before resolving the docs and key-semantics threads. - **Tests:** The `RestUtilTest` cases you listed, plus `ConfigBuilderTest.testInvalidPathKeysSurviveConfigShadeRoundTrip` and `RestApiSubmitJobConfigShadeDecryptTest.testSubmitJobWithRegexFieldInJson`, target the decrypt re-parse and REST submit boundaries I raised. I'll verify them against `509fddabe` before resolving those threads. - **Shared conversion path:** I'll also check on `509fddabe` whether the quoting lives in the shared `ConfigBuilder.of(Map)`/`ConfigShadeUtils` path or only in `RestUtil`, and follow up here with what I find. - **PR title:** if the change is confined to `seatunnel-engine-server`, please rename to `[Fix][Zeta]`; if it also touches the shared core builder, `[Fix][Core]` is fine. <!-- streview-comment:2031 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
