SEZ9 commented on PR #12511: URL: https://github.com/apache/seatunnel/pull/12511#issuecomment-6433039266
Thanks @Vivek1106-04 for closing the loop on the `abandonRestore` test coverage. Naming both tests in part 3 of the PR description — `CheckpointErrorRestoreEndTest#testCancelDuringPipelineRestoreWaitEndsTheJobCanceled` for the cancel branch and `SavePointTest#testSavePointFailureDuringPipelineRestoreWaitEndsTheJob` for the non-cancel branch — is exactly what I was after, and the reasoning that the non-cancel test would time out without `abandonRestore` (pipeline stuck `RUNNING`, job stuck in `DOING_SAVEPOINT`) makes the pin convincing. Since the code is unchanged since `a691fb195` and the description now documents the coverage, I consider this point resolved. Nothing further from me on it; @nzw921rx has also given a +1, so I'm good to move forward. <!-- streview-comment:2079 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
