SEZ9 commented on PR #12511: URL: https://github.com/apache/seatunnel/pull/12511#issuecomment-6487205867
Thanks @Vivek1106-04 for the follow-up, and thanks @nzw921rx for the +1. Where this stands from my side on head `a691fb195d`: - The code is unchanged since my last review, so my existing source-side clearance stands. The named tests for both branches of `abandonRestore` (`CheckpointErrorRestoreEndTest#testCancelDuringPipelineRestoreWaitEndsTheJobCanceled` for cancel, `SavePointTest#testSavePointFailureDuringPipelineRestoreWaitEndsTheJob` for non-cancel) close the coverage-documentation discussion from the thread. The earlier green run on `a691fb195` still applies, and the latest `Build` on `a691fb195d32381b3a43560eba4586861366a6d8` is `SUCCESS` as well. - The non-blocking notes from my last review (landing #12623 right after this, and treating a `FAILING` job like `CANCELING` in `abandonRestore`) remain non-blocking; no action needed on them in this PR. I have no remaining source-side blocker and nothing further to ask of you on this scope. The only outstanding item is the effective repository approval / branch-protection gate, which has to be handled by a committer with write access. The branch is `diverged` against `dev` but reports no merge conflict, so I am not requesting a rebase. <!-- streview-comment:2118 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
