SEPURI-SAI-KRISHNA commented on PR #13012:
URL: https://github.com/apache/seatunnel/pull/13012#issuecomment-6439275580
Fix looks correct, and good that you caught both call sites rather than one.
One more site has the same defect, line 279:
```java
if (columnList.toUpperCase().startsWith("DISTINCT ")) {
columnList = columnList.substring(9).trim();
}
```
`ſt` (U+FB05) and `st` (U+FB06) uppercase to `ST`, and `DISTINCT` contains
`ST`:
```
"distinct foo" len 11 -> "DISTINCT FOO" len 12
startsWith("DISTINCT ") true
substring(9).trim() "oo" (should be "foo")
regionMatches(true,0,"DISTINCT ",0,9) false
```
Same class as yours, and `regionMatches` fixes it. Yours to take, or say so.
`ALL ` on the next line, the `where` check at 554, and lines 174 and 339 are
safe.
Overlap worth knowing about: my open #12996 pins `toUpperCase(Locale.ROOT)`
at 7 sites in this file for #12995, a locale bug. Two of them are lines you
delete, and your version is better there. We conflict in both files, so whoever
lands second resolves.
Two notes: no CI has run on your branch, so you may need Actions enabled on
your fork. And spotless runs under JDK 17; it does break on 21 as you describe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
