SEPURI-SAI-KRISHNA commented on PR #13012:
URL: https://github.com/apache/seatunnel/pull/13012#issuecomment-6464707797
@rwzdk you are right, and my suggestion was wrong.
`Character.toLowerCase('İ')` is `'i'`, so `regionMatches(true, ...)` accepts
`distİnct *` where the current rule does not, while `diſtinct Q*` goes the other
way. It trades one mis-slice for another, so leaving line 279 alone is the
right call.
On the helper: agreed it is the cleaner primitive, a match that is ASCII
case-insensitive and returns the length it consumed. I would keep it out of
#12996, which stays scoped to the locale fix it was reviewed for. Once both PRs
land, the reproducible cases are fixed, and the helper would only change
behaviour on inputs like the ones above, which no JDBC dialect produces. So I
would only do it if a maintainer asks for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
