SEZ9 commented on PR #10643: URL: https://github.com/apache/seatunnel/pull/10643#issuecomment-6486234648
Thanks for the update on this one. On the review side: the follow-up scan on head `1d50ab8212032104e46d4f2f4b465981526802b6` reports the previous source conclusion (review 5678873675) as clear for the reviewed scope — the `ClientExecuteCommand` / `ClientCommandArgs` points around the hard-coded localhost client address, local-mode member binding, TCP/IP member-list clearing, `-port` handling outside local mode, the `ClientCommandArgsTest` coverage, and the `-port`/`--hazelcast-port` docs. I'm not reopening any of those here. What is still blocking is CI, not source: - [Build run 122625517828](https://github.com/apache/seatunnel/runs/122625517828) is `TIMED_OUT`. - [all-connectors-it-3 (17)](https://github.com/chl-wxp/seatunnel-laowang/actions/runs/40630477103/job/122626515868) and [all-connectors-it-3 (11)](https://github.com/chl-wxp/seatunnel-laowang/actions/runs/40630477103/job/122626515908) are `cancelled`. A cancelled job doesn't establish a product failure, so no code change is being asked for because of it, and a base sync alone isn't a remedy for it either. Concrete asks: 1. Please rerun the two cancelled `all-connectors-it-3` jobs (and the timed-out build) through the existing workflow and drop a note here once they finish, so the gate is based on an actual result rather than inference. 2. If the rerun surfaces a real failure in these jobs, please paste the failing assertion/log snippet in the thread so we can judge whether it is related to this change. Separately, there may still be an older CHANGES_REQUESTED state in the review summary that the COMMENT-only follow-up did not dismiss; a write-capable maintainer will need to reconcile that once CI is green. Nothing else is needed from you on that part. <!-- streview-comment:2109 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
