SEZ9 commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6513469797
Thanks for the CI follow-up. On head `4cfc9b02bfee4a326e042b79e53b7bcfe1fad857`, Signal pull request update, Lint, and the Python 3.9 / 3.10 / 3.13 test jobs are `SUCCESS`; the Build failure (122810157253) is limited to doris-connector-it (11), run 40668142760 / job 122749217860, where DorisSchemaChangeIT fails because the Doris container does not open its mapped ports within the startup window. That looks like a container-startup issue rather than a `found: false` assertion failure. Please rerun that job; if it repeats, please share the container startup log. No unrelated Doris change is needed in this PR. From the earlier review, these points still appear open (please point me to the commit if any are already addressed): 1. **Docs for `found: false`** – the payload is also returned by the deprecated `/running-job/:jobId` endpoint and the v1 endpoints, but only the v2 `/job-info` section of `docs/en/engines/zeta/rest-api-v2.md` was updated. Please update the other entries to match. 2. **CLI post-submit polling** (`seatunnel-cli/seatunnel_cli/cli.py`) – polling currently aborts on the first status-less or non-dict body and reports "job is not known to the cluster". Please only treat an explicit `found: false` as "not known", keep retrying on ambiguous bodies, or surface a distinct message for a non-JSON response. 3. **Polling message wording** – "The id may be wrong" is misleading when the id came straight from `/submit-job`; please reword. 4. **UI `fetch` error path** (`seatunnel-engine/seatunnel-engine-ui/src/views/jobs/detail.tsx`) – a rejected `getJobInfo` still leaves the page blank, so the new missing-job state never renders. Please add a catch that sets an error/not-found state. 5. **UI "Job not found" text** – please include the job id that was looked up. 6. **`JobsApi.job_exists`** (`tools/seatunnel-python-sdk/seatunnel/endpoints/jobs.py`) – a non-dict payload currently returns `False`; please distinguish a non-JSON response from an explicit `found: false`. Once these are pushed and the Doris job has been rerun, I'll take another pass. <!-- streview-comment:2132 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
