wgzhao commented on PR #12904:
URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6516019517
Thanks @SEZ9 and @DanielLeens. I reran the only failed job,
`doris-connector-it (11)` (run `40668142760`, attempt 2, in progress). That job
is an existing container-based Doris integration suite; it does not exercise
the `job-info` endpoint, so its failure is unrelated to this diff. I'll report
the result here.
The head is unchanged at `4cfc9b02b`, and all six points were addressed in
commit `6847d86cc` (the feature commit; `4cfc9b02` only moves
`vi.useRealTimers()` into `afterEach`). Pointers on the current head:
1. **`found: false` docs** — v1 `/hazelcast/rest/maps/job-info/:jobId`:
`docs/en/engines/zeta/rest-api-v1.md:402-439` (ZH `:422-457`); v1
`/hazelcast/rest/maps/running-job/:jobId`: `rest-api-v1.md:520-533` (ZH
`:514-527`); v2 deprecated `/running-job/:jobId`:
`docs/en/engines/zeta/rest-api-v2.md:809-822` (ZH `:796-809`); v2
`/job-info/:jobId`: `rest-api-v2.md:678-732` (ZH `:669-719`).
2. **CLI post-submit polling** —
`seatunnel-cli/seatunnel_cli/cli.py:1360-1400`: polling stops only on an
explicit `found: false` (`:1375`); one status-less or non-dict 200 is tolerated
(`:1388-1389`), and a repeat prints a distinct response-shape / master-failover
message (`:1392-1395`) instead of treating the id as unknown.
3. **Polling wording** — the only "id may be wrong" sentence is in
`run_diagnose`'s HTTP 404 branch (`cli.py:1659`), where the id is
user-supplied; `_poll_job_status` does not contain it.
4. **UI fetch error path** —
`seatunnel-engine/seatunnel-engine-ui/src/views/jobs/detail.tsx:95-155`: an
initial-load rejection sets `loadError` and renders the error card
(`:143-146`); a post-load rejection keeps the loaded page, warns once per error
streak (`:149-152`) and retries (`:153`). Covered by `detail.spec.ts` cases
"should show an error result when getJobInfo rejects" and "should keep the
loaded job when a refresh is rejected".
5. **UI not-found text** — `detail.tsx:616` passes `{ jobId }` to
`detail.notFound.description`; `detail.spec.ts:187-188` asserts that the route
id `123456789` is rendered.
6. **`JobsApi.job_exists`** —
`tools/seatunnel-python-sdk/seatunnel/endpoints/jobs.py:90-106`: a non-dict /
non-JSON body raises `TypeError` (`:100`) before `found` is checked
(`:104-105`); `test_sdk.py:114-159` covers the explicit marker, the
older-server fallback, the status-less case and the non-JSON case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
