Nikk8091 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6334685810
Hi, I'd like to request a focused `connector-cdc-opengauss` Source URL-validation slice. I checked dev at `99ea16b9d6bdce452d4c4955581ccc7236a81bbd`, this tracker and related open/closed PRs. `OpengaussIncrementalSourceFactory.optionRule()` requires `JdbcCommonOptions.URL` for presence without a nonblank constraint; the inherited base rule does not add one. I did not find a matching claim or implementation PR for this specific rule. This is a source inspection, not a claim that I have run the regression yet. I propose adding only `Conditions.notBlank(JdbcCommonOptions.URL)` in the OpenGauss factory and extending its existing factory tests through `ConfigValidator`. Coverage would include valid, missing, empty, whitespace-only and padded nonblank URLs, the `base-url` fallback, canonical-key precedence and the existing table-selection alternatives. Nonblank values must remain unchanged, and removing the new condition should make the blank-value regressions fail. I would preserve OpenGauss startup/stop choices, the shared PostgreSQL runtime, driver selection, credentials, replication, connection/retry behavior and all runtime checks. Any documentation adjustment would be limited to the EN/ZH URL contract, with a configuration-check regression in the existing OpenGauss CDC E2E suite. One coordination point: #11556 does not implement this factory rule, but it does touch the OpenGauss documentation and `OpengaussCDCIT`. Could you confirm whether this separate validation slice is available and can proceed with coordinated edits, or should wait for #11556? I will wait for confirmation before implementing and keep this separate from my DB2/Postgres PRs. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
