SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6356836676
Thanks @Nikk8091 for implementing the approved `connector-cdc-postgres` Source URL validation slice and for the detailed validation summary. The described scope matches what was agreed: the nonblank condition on the existing required URL rule, the EN/ZH doc updates, and factory tests covering missing, empty, whitespace-only, and padded values while keeping the `base-url` fallback, canonical-key precedence, and both table-selection alternatives covered. Showing that the regression cases fail without the rule and pass with it is exactly the evidence we want for a validation-only change, and thanks for being explicit about not claiming a container-test pass without Docker. I have only your report on the CI situation, so let's keep further implementation and CI discussion on the PR itself as you suggested. Once CI has run, please mark the PR ready for review and leave a note there so a maintainer can pick it up. <!-- streview-comment:1970 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
