DanielLeens commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6340367826
Thanks for doing the source and duplicate audit before starting work. Classification: F / CDC OpenGauss source configuration validation. Current `dev` confirms that `OpengaussIncrementalSourceFactory.optionRule()` requires `JdbcCommonOptions.URL` for presence but does not apply a nonblank condition, so the proposed factory-level validation boundary is technically sound. There is an active related change, however: #11556 currently modifies the OpenGauss CDC EN/ZH documentation and `OpengaussCDCIT`. Your proposed documentation and configuration-check coverage would overlap those files. To avoid a parallel/conflicting implementation, please wait for #11556 to merge (or for its author to coordinate an updated base) before opening this slice as a PR. After that dependency is settled, the scoped change may proceed: add only `Conditions.notBlank(JdbcCommonOptions.URL)` to the OpenGauss factory, extend the existing factory tests for missing/blank/padded/fallback/canonical-key cases, add the existing OpenGauss E2E configuration-check coverage, and update the corresponding EN/ZH URL contract. Keep startup modes, PostgreSQL runtime behavior, credentials, replication, and retry logic unchanged. No new `help wanted` or assignment change is made here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
