DanielLeens commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-6557483341
Thanks @SEZ9. Checked against the unchanged head: - F1/F5: the 3.5 `.cmd` uses `setlocal disabledelayedexpansion` at line 17; it does not use `!CMD!`/`!errorlevel!`. Java runs directly at `:54`, its status is saved on the next top-level line, and `:61-64` returns that saved nonzero code even with empty stdout. `TestSpark35StarterJarContentIT` exercises real native-Windows help/failure/config paths; source string assertions alone are not the execution proof. - F2/F6: the 3.5 `.sh` has no eval fallback. It quotes CLASS_PATH, receives raw NUL-separated arguments and invokes the quoted array. The older 2.x/3.3 scripts are distinct, unchanged launchers. - F4: `seatunnel-core/pom.xml` copies `log4j-slf4j-impl` for the starter JVM's SLF4J 1.7 API. The Spark parent shade exclusions remove **both** bindings from the starter jar; the separate Spark-submit JVM uses Spark's own logging distribution. The 3.5 dependency exclusions do not select a second provider for starter/logging. - F3: the 3.5 starter explicitly depends on the 3.3 translation artifact; runtime encoder lookup and explicit commit-coordinator behavior are the intended adaptation, not blanket compatibility certification. - F7/F8: `docs/en/engines/spark.md:19-30` and quick-start `:105-115` retain the existing starter for Spark 3.4 and recommend batch for 3.5. A bounded micro-batch adapter test exists (`Spark35BatchWriteTest:73`), but the docs correctly do not claim full 3.5 streaming-template validation. CI is still red in the previously identified Ubuntu Redis JDK17, engine JDK11 backpressure and cancelled connector-part-3 lane. The relevant backpressure fix #12316 is in latest dev and absent from this head; synchronize that fix before rerunning those gates, then investigate Redis separately if it repeats. This is a targeted CI recommendation with an identified upstream fix, not a branch-age-only request. No new source finding is added. Checked 2026-11-01T11:44:42.189441+00:00; unchanged head `5184b37259aad7f671cea4936dde13bec27cb92e`, base `dev`; compare `diverged`, ahead 70 / behind 77; merge `blocked` / `BLOCKED`; review decision `REVIEW_REQUIRED`. Behind/diverged is recorded independently and does not itself request a sync. Daniel has READ repository permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
