SEZ9 commented on PR #12922: URL: https://github.com/apache/seatunnel/pull/12922#issuecomment-6567532864
Thanks for the detailed pointers on 74235a4c2, @fatmanverse. 1. **Validate before submit** — the two-phase shape you describe (map every entry through `validatedSubmitJobsParams` first, then loop `submitJobInternal`) is what I was after. I'll confirm it against the diff at 74235a4c2 before closing this one out. Residual config/cluster-dependent failures (invalid config, missing savepoint) are fine as long as the Javadoc and docs say so, as you note. 2. **jobId messages** — switching `checkStartWithSavePoint` to `StringUtils.isBlank` so a blank `jobId` gets `Please provide jobId when start with save point.` sounds like the right fix for the blank-jobId point; I'll verify it at the new head as well. Your comment appears to have been cut off right after "Non-integer string `jobId` / `restoreSourceJobId` (including an oversized" — the rest of point 2 and the remaining points did not come through. Could you repost them? Specifically I still need to see: - The message now produced for a non-integral / oversized `jobId` or `restoreSourceJobId` (e.g. `1e3`, `1.5`, a 20-digit id) — does it name `params.jobId` rather than surfacing the raw `NumberFormatException` text? - Whether `RestUtilSubmitJobsParamsTest` now covers the `null`-value skip and empty-string acceptance that the docs advertise. - Whether `JobInfoServiceSubmitJobsTest` now pins the nested-value rejection and the mixed-order case (later bad entry blocks all submissions) end to end. - Whether the `params` table in `rest-api-v2.md` was updated so the value types match the new paragraph and `restoreMode` / `restoreSourceJobId` are listed. - Whether the client-supplied key in the nested-value error message is bounded/sanitized before it is logged at ERROR. - Whether the `buildRequestParams(Map, Map)` overload was renamed to disambiguate it from `buildRequestParams(Map, String)`. Once the missing half is up I'll go through all the items against 74235a4c2. <!-- streview-comment:2206 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
