fatmanverse commented on PR #12922: URL: https://github.com/apache/seatunnel/pull/12922#issuecomment-6547199685
The PR description still described the first commit: it named `RestUtil#buildRequestParams(Map, Map)`, which is now `buildRequestParamsFromJson`, and it left out the later changes. I have rewritten it for the current head 74235a4c2 and checked the docs boxes. It now covers validating every entry before submitting any, the HTTP 400 cases (nested values, non-integer numbers, string IDs that are not `long`, blank `restoreSourceJobId`), the blank-`jobId` savepoint check, and the unit and integration tests. The code is unchanged. Re-checked on JDK 17 with this head merged into the latest `dev` (f3e1c2ee3), which includes #13030 and #13068 that touch the REST tests: `seatunnel-engine-server` unit tests 709 run, 0 failures; `RestApiIT#testSubmitJobs*` 2/2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
