SEZ9 commented on PR #12922: URL: https://github.com/apache/seatunnel/pull/12922#issuecomment-6552372611
Thanks for refreshing the description to match head 74235a4c2, and for the JDK 17 run against `dev` at f3e1c2ee3. Since you note the code is unchanged, I'd like to confirm that the description and the head line up on the points from my earlier pass. Could you point me at the relevant spots? 1. **Validate-before-submit** — the description says every entry is validated before any is submitted. Do the per-entry `params` checks (savepoint/jobId, dry-run, restoreMode) now run before the submit stream, or can a bad entry N still return 400 after entries 0..N-1 are already on the cluster? 2. **Blank `jobId` + savepoint** and **non-integer / oversized numeric `jobId`** — are these rejected with a message that names `params.jobId`, rather than falling through to `restoreSourceJobId is required when restoreMode=SAVEPOINT` or a raw `NumberFormatException` text? 3. **Tests** — is the `null`-value skip / empty-string acceptance covered in `RestUtilSubmitJobsParamsTest`, and does `JobInfoServiceSubmitJobsTest` include a nested-value rejection case and a mixed-order case where a later bad entry blocks all submissions? The pass counts tell me things pass, not what is covered. 4. **Docs** — does the `params` table now type values as number/boolean where applicable and include `restoreMode` / `restoreSourceJobId`? 5. **Error message with client key** — is the `params` key in the nested-value message bounded or sanitized before it reaches the ERROR log? 6. **`buildRequestParamsFromJson` rename** — I'd like to see this in the diff; if the overload is gone at the head, that closes my naming/ambiguity concern. If any of these are not in the head yet, a small follow-up commit is fine; if they are, just point me at them and I'll re-review. <!-- streview-comment:2181 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
