88fantasy commented on PR #12209:
URL: https://github.com/apache/seatunnel/pull/12209#issuecomment-6646294793
Thanks @SEZ9 for re-checking the three commits after `ca7867c583`.
Those commits are mostly comment/Javadoc + the shared-foundation sync, so
the F1 / F3 guards do not show up in that delta. They landed earlier on this
branch (and in the shared `#12208` modules) and are still present on tip
`8434902b288fed7c6c06e315ab49583e7b2920e7`. Pointers:
**F1 (blocking — job must not redirect a cluster/env token)**
The guard is in the shared resolver, not in a `JobMaster.java` diff:
- `LineageConfig.resolve`
(`seatunnel-lineage/.../LineageConfig.java:131-150`) rejects a job-supplied
token first (`rejectJobAuthToken`), then resolves URL/transport via
`receiverOption`.
- When a process-env or cluster token is present, `receiverOption`
(`:312-338`) takes `openlineage_url` / `openlineage_transport` only from those
trusted layers. A job value that differs throws
`"… must match the environment or cluster receiver when an auth token is
configured"`
without echoing the secret.
- `JobMaster.resolveLineageConfig` goes through this path, so a submitter
cannot attach the cluster bearer token to an arbitrary URL.
- Regression coverage:
`rejectsJobReceiverOverridesWhenAClusterTokenIsConfigured`,
`bindsEnvironmentTokensToTrustedReceiverOptions` (and related token-binding
tests) in `LineageConfigTest`.
`openlineage_enabled` can still be set by the job; that only opts the job's
own run in or out. It does not change where the token is sent.
**F3 (try/catch around extractor)**
Already present on tip in
`MultipleTableJobConfigParser.extractLineageDatasets` (`:388-399`): ordinary
extractor failures become an empty list, `VirtualMachineError` is rethrown, and
the warning logs only the factory id and exception class. The recent Javadoc
documents that existing guard; it is not the only change.
**Follow-ups (as you offered)**
Happy to keep this PR focused and land **F2 / F4 / F5 / F6 / F8** (and any
remaining docs polish under F6/F7) as follow-ups after merge, unless you prefer
any of them in this PR.
Could you please re-check tip `8434902b288fed7c6c06e315ab49583e7b2920e7`
against the locations above and clear the outstanding `CHANGES_REQUESTED` if F1
looks resolved on your side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
