DanielLeens commented on PR #12209: URL: https://github.com/apache/seatunnel/pull/12209#issuecomment-6655659742
Thanks @88fantasy, that matches my reading. On head `8434902b288f`, the residual follow-ups are exactly F4 (advance the lineage throttle timestamp only after a successful emit, or reset it on failure, so a failed emit does not swallow the next interval) and a typed config holder to replace the raw lineage map in `EngineConfig`. Neither is a merge blocker, and a single follow-up issue after merge works well. The docs and secret masking were already addressed earlier, so the issue does not need to carry any F6/F8 docs items unless you find something new. My approval on this head stands, and Apache CI is green. The remaining gates are outside my review: @SEZ9's own decision on the recorded `CHANGES_REQUESTED`, a write-capable committer approval, and landing #12208 first or together with this PR. Thanks again for the careful pointers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
