88fantasy commented on PR #12209:
URL: https://github.com/apache/seatunnel/pull/12209#issuecomment-6652570082

   Thanks @DanielLeens for the review and approval, and for the correction.
   
   You're right: F2 (bounded worker waits) and F5 (operator timeout/retry 
limits) are already implemented on this branch 
(`JobMaster.resolveLineageConfig:1180-1189` and 
`getCurrentJobMetricsForLineage`). So the remaining follow-ups are narrower:
   
   - F4: make the lineage interval strictly best-effort (only advance the 
throttle timestamp after a successful emit, or reset it on failure)
   - A typed config holder for lineage options (replacing the raw map in 
`EngineConfig`)
   
   I'll open a follow-up issue for these after merge. Any docs polish under 
F6/F8 can go in the same issue if needed.
   
   @SEZ9, could you re-check tip `8434902b288fed7c6c06e315ab49583e7b2920e7` 
when you have a moment? If F1 looks resolved on your side, please clear the 
outstanding `CHANGES_REQUESTED` so the PR is unblocked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to