DanielLeens commented on PR #12623:
URL: https://github.com/apache/seatunnel/pull/12623#issuecomment-6730695916

   Thanks @Vivek1106-04, this is exactly the boundary I asked for. I re-read 
the description on the unchanged head 
`caa5f098fc0a5c6dd887ba8632dc43d463eb4580`: the "Scope of the evidence in this 
PR" paragraph states clearly that the `StateTransitionCleanupTest` cases are 
vertex-level, that they do not prove the full #12622 restore-wait -> 
`forceStopPipeline()` -> leave `DOING_SAVEPOINT` scenario, and that #12622 is 
only fully addressed once #12511 has also landed. The refreshed test section 
(20 tests at this head, plus the revert result) also matches what you posted 
earlier.
   
   I agree that a `SubPlan`-level test here would not add evidence once 
#12511's post-wait re-check is in, so I am fine with treating it as out of 
scope for this PR. Whether that closes F2 is @SEZ9's call. F1 stays as agreed: 
re-check after #12511 merges (#12511 is still open right now).
   
   My approval on this head stands, with the same merge-order note: please land 
#12511 first. Nothing else is needed from you for now. Final approval and merge 
remain with a write-capable maintainer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to