SEZ9 commented on PR #12623: URL: https://github.com/apache/seatunnel/pull/12623#issuecomment-6817980108
Thanks @Vivek1106-04, and apologies for the slow reply to your 2026-11-07 comment. **F2.** Agreed: I'm fine treating the `SubPlan`-level test as out of scope for this PR. Your reasoning holds — once #12511's post-wait re-check is in, a restore-wait -> `forceStopPipeline()` -> leave `DOING_SAVEPOINT` test here would pass with or without this change, so it would not add evidence for this fix. The "Scope of the evidence" paragraph in the description (vertex-level tests only, full #12622 scenario depends on both PRs landing) is exactly the boundary I wanted stated, and the refreshed test section (20 tests at this head plus the revert result, replacing the stale 6-test list from `f24ed531e`) is appreciated. I consider F2 closed on `caa5f098f`. **F1.** Also agreed: no change in this PR, and no action from you now. I will re-check it once #12511 merges; the merge-order note in the description (#12511 first) stands. Nothing further needed from you at the moment. Please don't push anything to this head until #12511 lands so the evidence here stays tied to `caa5f098fc0a5c6dd887ba8632dc43d463eb4580`; if #12511 changes the `SubPlan.prepareRestorePipeline()` behaviour in a way that affects this PR's `PhysicalVertex.java` change, I'll flag it under F1 at that point. <!-- streview-comment:2292 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
