SEZ9 commented on PR #12209: URL: https://github.com/apache/seatunnel/pull/12209#issuecomment-6993698565
Thanks for the update on `d51ebfc095`. Here is where the earlier review points stand, based on the latest re-review in this thread. **Closed** The re-review reports that the previous source blockers are closed and that the conflict resolution preserves the earlier fixes. In particular: - The parser now rejects a receiver token in job options. - Dataset extraction in `MultipleTableJobConfigParser` is wrapped in a real try/catch: ordinary extraction failures return an empty list, while `VirtualMachineError` still propagates. - Lineage events are delivered through an isolated, bounded pool, with pending RUNNING events coalesced per job. **Agreed follow-ups** - Heartbeat delivery acknowledgement, so the throttle is not advanced before delivery is known to succeed. - A typed settings holder for the cluster `auth_token`, so it is no longer kept as plain text in a raw map. Deferring both is fine with me. If tracking issues exist for them, could you link them here so they don't get lost? Beyond those two follow-ups, I have nothing further on the previous source review points. <!-- streview-comment:2440 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
