SEZ9 commented on PR #12209: URL: https://github.com/apache/seatunnel/pull/12209#issuecomment-7025680072
Thanks for the continued work on this. Two follow-ups remain, both on the earlier point about bounding `openlineage_timeout_ms` / `openlineage_retry_times` so one job cannot pin the shared lineage pool. The latest review notes that both carry over from the previously cleared version and were not introduced by the merge. 1. **Disabled-config edge in budget resolution.** The trusted limits are currently resolved through the ordinary reporting resolver. When that resolver sees reporting as disabled, the administrator limits are replaced with defaults. Could you resolve the administrator limits on a path that does not depend on the reporting-enabled state, so the configured upper bounds are always the ones applied? 2. **The bounds test does not exercise the bounds check.** The new test never enables reporting, so it gets defaults back and never enters the bounds check. The latest review reports that the unit log shows this assertion failing. Please enable reporting in the test setup so it reaches the check. It would also help to add a case for the disabled-config edge in item 1, asserting that the administrator limits survive. The other previously raised points stay closed, so nothing further is needed on those. Once both changes are pushed, please reply here with a short note on how the limits are now resolved, and I'll take another look. <!-- streview-comment:2470 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
