kenhuuu commented on code in PR #1833:
URL: https://github.com/apache/tinkerpop/pull/1833#discussion_r1001318935
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java:
##########
@@ -205,6 +205,7 @@ private static Builder getBuilderFromSettings(final
Settings settings) {
.maxConnectionPoolSize(settings.connectionPool.maxSize)
.minConnectionPoolSize(settings.connectionPool.minSize)
.connectionSetupTimeoutMillis(settings.connectionPool.connectionSetupTimeoutMillis)
+
.sslHandshakeTimeoutMillis(settings.connectionPool.sslHandshakeTimeoutMillis)
Review Comment:
I understand the concern of there being too many configuration options for
the user already, but I'm not sure if there is a reasonable default for this as
a percentage of connectionSetupTimeoutMillis. Would it make sense then to just
set this value to 0 (no timeout). This would allow the user to focus on just
setting a proper value for connectionSetupTimeoutMillis which will cap the SSL
handshake anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
